Skip to content

Make object literal properties new identifier locations when not contextually typed#42612

Merged
andrewbranch merged 3 commits intomicrosoft:masterfrom
andrewbranch:bug/42595
Feb 3, 2021
Merged

Make object literal properties new identifier locations when not contextually typed#42612
andrewbranch merged 3 commits intomicrosoft:masterfrom
andrewbranch:bug/42595

Conversation

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Feb 2, 2021 •
edited
Loading

Fixes #42595

Kapture 2021-02-02 at 10 54 46

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 2, 2021
@andrewbranch
Copy link
Member Author

andrewbranch commented Feb 2, 2021

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 2, 2021 •
edited
Loading

Heya @andrewbranch, I've started to run the tarball bundle task on this PR at 581ad93. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 2, 2021 •
edited
Loading

Hey @andrewbranch, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/94734/artifacts?artifactName=tgz&fileId=9BC4F63633CFF0695B4863FD92134399535943BD860CDE9B66D1BF268DBF601702&fileName=/typescript-4.2.0-insiders.20210202.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.2.0-pr-42612-2".;

DanielRosenwasser
DanielRosenwasser requested changes Feb 2, 2021
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for comma tokens.

@andrewbranch andrewbranch merged commit 96cc9b9 into microsoft:master Feb 3, 2021
@andrewbranch andrewbranch deleted the bug/42595 branch February 3, 2021 00:17
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

@andrewbranch andrewbranch

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Methods are not new identifier definition locations

4 participants

@andrewbranch @typescript-bot @DanielRosenwasser @sheetalkamat